You cannot select more than 25 topics
Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
![]() * Moved contents of rgblight_reconfig.h to rgblight_post_config.h. In #3582, rgblight_reconfig.h had to be newly created. Now, the build system of qmk_firmware has a post_cofig feature, so that what was done in rgblight_reconfig.h can now be realized in rgblight_post_config.h. **This commit does not change the build result.** Testing script ```shell # build on master git checkout master echo master > /tmp/master_md5.txt # RGBLIGHT_ENABLE = no make HELIX=verbose helix/rev2:default:clean make HELIX=verbose helix/rev2:default md5 helix_rev2_default.hex >> /tmp/master_md5.txt # RGBLIGHT_ENABLE = yes, with animations make HELIX=verbose helix/rev2/back:default:clean make HELIX=verbose helix/rev2/back:default md5 helix_rev2_back_default.hex >> /tmp/master_md5.txt # RGBLIGHT_ENABLE = yes, without animations make HELIX=verbose,no_ani helix/rev2/back:default:clean make HELIX=verbose,no_ani helix/rev2/back:default md5 helix_rev2_back_default.hex >> /tmp/master_md5.txt # build on refactor_rgblight_reconfig.h git checkout refactor_rgblight_reconfig.h echo refactor_rgblight_reconfig.h > /tmp/branch_md5.txt # RGBLIGHT_ENABLE = no make HELIX=verbose helix/rev2:default:clean make HELIX=verbose helix/rev2:default md5 helix_rev2_default.hex >> /tmp/branch_md5.txt # RGBLIGHT_ENABLE = yes, with animations make HELIX=verbose helix/rev2/back:default:clean make HELIX=verbose helix/rev2/back:default md5 helix_rev2_back_default.hex >> /tmp/branch_md5.txt # RGBLIGHT_ENABLE = yes, without animations make HELIX=verbose,no_ani helix/rev2/back:default:clean make HELIX=verbose,no_ani helix/rev2/back:default md5 helix_rev2_back_default.hex >> /tmp/branch_md5.txt diff -u /tmp/master_md5.txt /tmp/branch_md5.txt ``` Test result: ``` --- /tmp/master_md5.txt 2020-01-03 15:42:22.000000000 +0900 +++ /tmp/branch_md5.txt 2020-01-03 15:42:42.000000000 +0900 @@ -1,4 +1,4 @@ -master +refactor_rgblight_reconfig.h MD5 (helix_rev2_default.hex) = f360032edd522448366d471d8f4f8181 MD5 (helix_rev2_back_default.hex) = 0c663acc6cccc44476b3b969ad22a48f MD5 (helix_rev2_back_default.hex) = e66b1195ff6d38e6e22c975b8ae42fd3 ``` * Expressions that are too long are difficult to read, so wrap them. * Edit the expression again * remove `defined(RGBLIGHT_ANIMATIONS)` in `tmk_core/common/*/suspend.c`, `tmk_core/protocol/*/main.c` move contents of rgblight_reconfig.h to rgblight.h. The following changes were made to rgblight.h. ```diff +#ifdef RGBLIGHT_USE_TIMER void rgblight_task(void); void rgblight_timer_init(void); void rgblight_timer_enable(void); void rgblight_timer_disable(void); void rgblight_timer_toggle(void); +#else +#define rgblight_task() +#define rgblight_timer_init() +#define rgblight_timer_enable() +#define rgblight_timer_disable() +#define rgblight_timer_toggle() +#endif ``` The following changes were made to tmk_core/common/avr/suspend.c, tmk_core/common/chibios/suspend.c, tmk_core/protocol/chibios/main.c, tmk_core/protocol/lufa/lufa.c, tmk_core/protocol/vusb/main.c. ```diff -# ifdef RGBLIGHT_ANIMATIONS rgblight_timer_enable(); -# endif ``` ```diff -#if defined(RGBLIGHT_ANIMATIONS) && defined(RGBLIGHT_ENABLE) +#if defined(RGBLIGHT_ENABLE) rgblight_task(); #endif ``` * remove 'defined(RGBLIGHT_ANIMATIONS)' in tmk_core/common/keyboard.c Co-authored-by: Joel Challis <git@zvecr.com> |
5 years ago | |
---|---|---|
.. | ||
api | 6 years ago | |
audio | 5 years ago | |
backlight | 5 years ago | |
debounce | 6 years ago | |
keymap_extras | 5 years ago | |
process_keycode | 5 years ago | |
rgb_matrix_animations | 5 years ago | |
rgb_matrix_runners | 6 years ago | |
serial_link | 5 years ago | |
split_common | 5 years ago | |
stm32 | 5 years ago | |
template | 5 years ago | |
tools | 9 years ago | |
visualizer | 5 years ago | |
api.c | 6 years ago | |
api.h | 6 years ago | |
color.c | 5 years ago | |
color.h | 5 years ago | |
config_common.h | 5 years ago | |
debounce.h | 6 years ago | |
dip_switch.c | 6 years ago | |
dip_switch.h | 6 years ago | |
dynamic_keymap.c | 5 years ago | |
dynamic_keymap.h | 6 years ago | |
dynamic_macro.h | 6 years ago | |
encoder.c | 5 years ago | |
encoder.h | 6 years ago | |
fauxclicky.c | 6 years ago | |
fauxclicky.h | 6 years ago | |
keycode_config.c | 6 years ago | |
keycode_config.h | 6 years ago | |
keymap.h | 6 years ago | |
keymap_common.c | 5 years ago | |
led_matrix.c | 6 years ago | |
led_matrix_drivers.c | 6 years ago | |
led_tables.c | 5 years ago | |
led_tables.h | 5 years ago | |
ledmatrix.h | 6 years ago | |
matrix.c | 5 years ago | |
matrix_common.c | 5 years ago | |
mcu_selection.mk | 5 years ago | |
pincontrol.h | 6 years ago | |
pointing_device.c | 6 years ago | |
pointing_device.h | 6 years ago | |
quantum.c | 5 years ago | |
quantum.h | 5 years ago | |
quantum_keycodes.h | 5 years ago | |
rgb.h | 6 years ago | |
rgb_matrix.c | 5 years ago | |
rgb_matrix.h | 5 years ago | |
rgb_matrix_drivers.c | 5 years ago | |
rgb_matrix_types.h | 6 years ago | |
rgblight.c | 5 years ago | |
rgblight.h | 5 years ago | |
rgblight_breathe_table.h | 6 years ago | |
rgblight_list.h | 6 years ago | |
rgblight_modes.h | 6 years ago | |
rgblight_post_config.h | 6 years ago | |
send_string_keycodes.h | 5 years ago | |
variable_trace.c | 6 years ago | |
variable_trace.h | 6 years ago | |
velocikey.c | 6 years ago | |
velocikey.h | 6 years ago | |
via.c | 5 years ago | |
via.h | 5 years ago |